Conversation
…s doing bad stuff
mgignac
reviewed
Feb 13, 2025
steering-files/src/main/resources/org/hps/steering/recon/PhysicsRun2021_pass1_recon.lcsim
Outdated
Show resolved
Hide resolved
mgignac
approved these changes
Feb 14, 2025
sarahgaiser
approved these changes
Feb 14, 2025
Collaborator
|
We will have to do the same for the MC drivers, don't we? |
Collaborator
Yes, we also need to update the MC steering file as well (then re-run MC) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was the cause of the problems with the momentum...I think it was basically kicking out good hits. The default for this is 50.0, the setter in the steering file had it at ~13, which is apparently too low.
See https://jira.slac.stanford.edu/browse/HPSANA-62